Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 16256017: Land Recent QUIC changes. (Closed)

Created:
7 years, 6 months ago by ramant (doing other things)
Modified:
7 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC changes. Merge internal change: 47341065 Fix to ensure the version matches before declaring that the public header flags exceed the max value. b/9190456 Merge internal change: 47324563 Fixing another backup bug (exposed by the last fix) that if we failed to write a standalone fin the stream would not be marked as write blocked. Merge internal change: 47272116 Don't add QuicStreams to ActiveSessionList; Instead call DumpSession on alive streams via QuicSession. Merge internal change: 47226512 Making the packet sequence number variable length to minimize bytes on the wire. Merge internal change: 47220850 Fixing a bug in quic stream where we'd send rst stream packets for successful streams. The fin bit should be sufficient for both good request/response pairs and early response pairs. Merge internal change: 47086343 Don't let FEC packets consume congestion window forever. If a FEC packet is not acked after a certain time, it is cleared from the congestion window. This timeout is higher than normal RTO. Merge internal change: 47056082 Add QuicSession to ActiveSessionList. Merge internal change: 47048300 Fixing a backup/resumption bug in QUIC. It's possible to have a full congestion window worth of packets on the wire. If we are in this state and a session tries to SendStreamData, the QuicPacketGenerator short-circuits without queuing packets because it checks to see if the connection CanWrite. When we get an ack, we check to see if we have locally queued packets, but never call OnCanWrite on the session to clear any streams which write blocked without queueing packets. Merge internal change: 47000173 QUIC: wire up the server-nonce parameters to the server config. Merge internal change: 46985067 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204289

Patch Set 1 #

Patch Set 2 : Android compilation fix #

Patch Set 3 : Windows compilation fix #

Patch Set 4 : Added GTEST_HAS_DEATH_TEST #

Patch Set 5 : Fix for Android DEBUG builds with DEATH_TEST #

Total comments: 4

Patch Set 6 : Fixed rch's comments #

Patch Set 7 : Merging with TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1201 lines, -419 lines) Patch
M net/quic/congestion_control/quic_congestion_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_config.h View 1 chunk +15 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_config.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 6 chunks +43 lines, -18 lines 0 comments Download
M net/quic/quic_connection.cc View 1 2 3 4 16 chunks +121 lines, -56 lines 0 comments Download
M net/quic/quic_connection_test.cc View 32 chunks +100 lines, -41 lines 0 comments Download
M net/quic/quic_framer.h View 3 chunks +8 lines, -5 lines 0 comments Download
M net/quic/quic_framer.cc View 1 2 33 chunks +155 lines, -59 lines 0 comments Download
M net/quic/quic_framer_test.cc View 71 chunks +497 lines, -103 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 2 3 4 5 5 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_packet_creator.h View 3 chunks +9 lines, -5 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 6 chunks +9 lines, -2 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 9 chunks +50 lines, -28 lines 0 comments Download
M net/quic/quic_protocol.cc View 5 chunks +30 lines, -26 lines 0 comments Download
M net/quic/quic_session.h View 4 chunks +11 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 8 chunks +15 lines, -8 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 8 chunks +12 lines, -47 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 3 chunks +9 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 1 2 3 4 4 chunks +63 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_framer_peer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_framer_peer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
ramant (doing other things)
7 years, 6 months ago (2013-06-03 18:32:23 UTC) #1
Ryan Hamilton
lgtm LGTM as I have reviewed all the appropriate CLs.
7 years, 6 months ago (2013-06-03 18:41:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/16256017/1
7 years, 6 months ago (2013-06-03 19:03:57 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-03 19:23:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/16256017/9002
7 years, 6 months ago (2013-06-03 19:25:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/16256017/11035
7 years, 6 months ago (2013-06-03 19:42:33 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-03 20:05:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/16256017/1036
7 years, 6 months ago (2013-06-03 20:19:32 UTC) #8
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
7 years, 6 months ago (2013-06-04 11:30:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/16256017/1036
7 years, 6 months ago (2013-06-04 16:17:54 UTC) #10
ramant (doing other things)
Committed patchset #4 manually as r204046 (presubmit successful).
7 years, 6 months ago (2013-06-04 21:13:20 UTC) #11
ramant (doing other things)
Hi Ryan, This CL is re-landing of the following CL with disabling DEATH_TEST for android ...
7 years, 6 months ago (2013-06-05 16:24:01 UTC) #12
Ryan Hamilton
lgtm Once more unto the breach! https://codereview.chromium.org/16256017/diff/28001/net/quic/quic_http_stream_test.cc File net/quic/quic_http_stream_test.cc (right): https://codereview.chromium.org/16256017/diff/28001/net/quic/quic_http_stream_test.cc#newcode354 net/quic/quic_http_stream_test.cc:354: ASSERT_TRUE(response_.headers.get() != NULL); ...
7 years, 6 months ago (2013-06-05 16:41:23 UTC) #13
ramant (doing other things)
https://codereview.chromium.org/16256017/diff/28001/net/quic/quic_http_stream_test.cc File net/quic/quic_http_stream_test.cc (right): https://codereview.chromium.org/16256017/diff/28001/net/quic/quic_http_stream_test.cc#newcode354 net/quic/quic_http_stream_test.cc:354: ASSERT_TRUE(response_.headers.get() != NULL); On 2013/06/05 16:41:23, Ryan Hamilton wrote: ...
7 years, 6 months ago (2013-06-05 16:55:39 UTC) #14
ramant (doing other things)
7 years, 6 months ago (2013-06-05 17:56:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #7 manually as r204289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698