Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 163733002: Fix build due to double declaration of TraceTrait<RefPtr<T> > (Closed)

Created:
6 years, 10 months ago by kenneth.r.christiansen
Modified:
6 years, 10 months ago
CC:
blink-reviews, Mads Ager (chromium)
Visibility:
Public.

Description

Fix build due to double declaration of TraceTrait<RefPtr<T> > Remove the double declaration. See some more discussion here: https://codereview.chromium.org/163493003/ NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M Source/heap/Handle.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kenneth.r.christiansen
6 years, 10 months ago (2014-02-13 15:01:07 UTC) #1
wibling-chromium
lgtm, but one of the changes originally adding the TraceTrait is already in the process ...
6 years, 10 months ago (2014-02-13 15:02:53 UTC) #2
kenneth.r.christiansen
On 2014/02/13 15:02:53, wibling-chromium wrote: > lgtm, but one of the changes originally adding the ...
6 years, 10 months ago (2014-02-13 15:05:24 UTC) #3
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 10 months ago (2014-02-13 15:07:40 UTC) #4
wibling-chromium
On 2014/02/13 15:05:24, kenneth.r.christiansen wrote: > On 2014/02/13 15:02:53, wibling-chromium wrote: > > lgtm, but ...
6 years, 10 months ago (2014-02-13 15:07:40 UTC) #5
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 10 months ago (2014-02-13 15:10:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 15:10:57 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-13 15:11:00 UTC) #8
Peter Beverloo
lgtm
6 years, 10 months ago (2014-02-13 15:11:20 UTC) #9
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 10 months ago (2014-02-13 15:11:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/163733002/1
6 years, 10 months ago (2014-02-13 15:11:39 UTC) #11
commit-bot: I haz the power
Change committed as 167091
6 years, 10 months ago (2014-02-13 15:12:12 UTC) #12
haraken
6 years, 10 months ago (2014-02-13 15:26:46 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698