Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 163493003: Revert of Move speech module over to Oilpan. (Closed)

Created:
6 years, 10 months ago by loislo
Modified:
6 years, 10 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, Mads Ager (chromium), abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Move speech module over to Oilpan. (https://codereview.chromium.org/139803012/) Reason for revert: compilation failed Original issue's description: > Move speech module over to Oilpan. > > This moves the speech/ interfaces over to using Oilpan transition > types. With the exception of the event objects, which will wait until > the base classes have been moved over. > > R=haraken@chromium.org, zerny@chromium.org > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167088 TBR=oilpan-reviews@chromium.org,haraken@chromium.org,tkent@chromium.org,zerny@chromium.org,jochen@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true BUG=340522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -261 lines) Patch
M Source/bindings/v8/Dictionary.h View 3 chunks +9 lines, -30 lines 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/heap/Handle.h View 2 chunks +0 lines, -16 lines 0 comments Download
M Source/heap/Visitor.h View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/speech/SpeechGrammar.h View 3 chunks +3 lines, -7 lines 0 comments Download
M Source/modules/speech/SpeechGrammar.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/modules/speech/SpeechGrammar.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechGrammarList.h View 3 chunks +3 lines, -7 lines 0 comments Download
M Source/modules/speech/SpeechGrammarList.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M Source/modules/speech/SpeechGrammarList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.h View 3 chunks +8 lines, -11 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionAlternative.h View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionAlternative.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionAlternative.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.h View 3 chunks +4 lines, -8 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.h View 1 chunk +5 lines, -12 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.cpp View 2 chunks +4 lines, -11 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.h View 1 chunk +3 lines, -7 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.cpp View 2 chunks +2 lines, -16 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesis.h View 5 chunks +8 lines, -11 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.cpp View 5 chunks +6 lines, -15 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.h View 3 chunks +4 lines, -8 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.h View 3 chunks +2 lines, -6 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSpeechRecognitionResult.cpp View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
loislo
Created Revert of Move speech module over to Oilpan.
6 years, 10 months ago (2014-02-13 14:24:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/163493003/1
6 years, 10 months ago (2014-02-13 14:37:20 UTC) #2
sof
Thanks, please go ahead & revert. Overlap with http://crrev.com/148523016, but neither were compiled on top ...
6 years, 10 months ago (2014-02-13 14:38:41 UTC) #3
wibling-chromium
On 2014/02/13 14:38:41, sof wrote: > Thanks, please go ahead & revert. > > Overlap ...
6 years, 10 months ago (2014-02-13 14:40:12 UTC) #4
sof
On 2014/02/13 14:40:12, wibling-chromium wrote: > On 2014/02/13 14:38:41, sof wrote: > > Thanks, please ...
6 years, 10 months ago (2014-02-13 14:45:15 UTC) #5
wibling-chromium
On 2014/02/13 14:45:15, sof wrote: > On 2014/02/13 14:40:12, wibling-chromium wrote: > > On 2014/02/13 ...
6 years, 10 months ago (2014-02-13 14:52:37 UTC) #6
sof
On 2014/02/13 14:52:37, wibling-chromium wrote: > On 2014/02/13 14:45:15, sof wrote: > > On 2014/02/13 ...
6 years, 10 months ago (2014-02-13 15:38:09 UTC) #7
wibling-chromium
6 years, 10 months ago (2014-02-13 15:42:41 UTC) #8
Message was sent while issue was closed.
On 2014/02/13 15:38:09, sof wrote:
> On 2014/02/13 14:52:37, wibling-chromium wrote:
> > On 2014/02/13 14:45:15, sof wrote:
> > > On 2014/02/13 14:40:12, wibling-chromium wrote:
> > > > On 2014/02/13 14:38:41, sof wrote:
> > > > > Thanks, please go ahead & revert.
> > > > > 
> > > > > Overlap with http://crrev.com/148523016, but neither were compiled on
> top
> > of
> > > > > each other while in the queue. I'll rebase and tidy up.
> > > > 
> > > > Thanks! From what I can tell it might as well have been me doing the
> > rebasing
> > > > and tidying up:p
> > > 
> > > No worries, I get what I deserve from "stealing" your TraceTrait
> > specialization
> > > :)
> > 
> > Thanks anyway.
> > 
> > Btw. did the commit of the reverted change just stop?
> 
> It did run into trouble, https://codereview.chromium.org/163733002/ tidied up
in
> the end.
> 
> I don't understand how two identical code chunks weren't collapsed into one
when
> merged, but lesson learnt.

Neither do I. I would have expected a merge failure.

Btw. I am seeing a build error with SpeechGrammer when building with oilpan
enabled. I will send out a patch for it.

Powered by Google App Engine
This is Rietveld 408576698