Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1637213002: Revert of MSE: Relax the 'media segment must begin with keyframe' requirement (Closed)

Created:
3 years, 3 months ago by wolenetz
Modified:
3 years, 3 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MSE: Relax the 'media segment must begin with keyframe' requirement (patchset #13 id:240001 of https://codereview.chromium.org/1091293005/ ) Reason for revert: Two regressions: BUG=581125, 581458 The latter causes NFLX playback stall. Reverting to fix canary, even if the latter's eventual fix might be external (e.g. NFLX web app). To allow revert to currently failing code format rules: NOPRESUBMIT=true Original issue's description: > MSE: Relax the 'media segment must begin with keyframe' requirement > > The current version of the MSE spec no longer requires that media segments > start with a keyframe. This change reworks the MSE implementation > so that it now allows tracks within media segments to not begin > with a keyframe. > > To accomplish this requirement's relaxation, this CL: > 1) Separates media segment signaling from coded frame group signaling: > MSE stream parsers need to report whether or not they are currently > in the middle of parsing a media segment, such as a WebM cluster, to > comply with spec disallowance of certain operations like changing > SourceBuffer appendMode when appendState is PARSING_MEDIA_SEGMENT. > However, SourceBufferStream only needs to be signaled when a new coded > frame group is beginning, for example when buffers are appended > following a discontinuity. > 2) Since the FrameProcessor now can transitively signal SourceBufferStreams > when a new coded frame group is beginning (which might span multiple > media segments), the SourceBufferStream can rely upon the fact > that the next buffer appended must be a keyframe if it's been told > that a new coded frame group is starting. A CHECK() is included. > 3) New ChunkDemuxerTests. > 4) Various test cleanup to conform to the distinct "new coded frame group" > and "new media segment" signaling separation, as well as removal > of decode error verification when a media segment doesn't begin > with a keyframe. > > Note that the FrameProcessor already drops non-keyframes prior to the > first keyframe processed for a track following a discontinuity, > and the SourceBufferStream already drops non-keyframes prior to the > first keyframe processed for a track following a range removal that > removed the last appended position in the current coded frame group. > > BUG=229412, 459546 > R=chcunningham@chromium.org > TEST=Updated ChunkDemuxerTests, SourceBufferStreamTests, > FrameProcessorTests. Also locally tested: bug 459546's > original report no longer fails. A sample webm VP9 file > from b/26524063 no longer fails. GPM webm vp9/opus test no > longer fails. Bug 518854's original report's "flags_all.mp4" > no longer fails. > > Committed: https://crrev.com/3d152e528e97024860822d3e75109c0c597bf4de > Cr-Commit-Position: refs/heads/master@{#371018} TBR=chcunningham@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=229412, 459546 Committed: https://crrev.com/4d3c457f2301754ca4321c77c8ff13e69dec8acc Cr-Commit-Position: refs/heads/master@{#371686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+634 lines, -784 lines) Patch
M media/filters/chunk_demuxer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 3 chunks +3 lines, -215 lines 0 comments Download
M media/filters/frame_processor.h View 5 chunks +9 lines, -12 lines 0 comments Download
M media/filters/frame_processor.cc View 9 chunks +30 lines, -34 lines 0 comments Download
M media/filters/frame_processor_unittest.cc View 29 chunks +50 lines, -32 lines 0 comments Download
M media/filters/media_source_state.h View 1 chunk +10 lines, -0 lines 0 comments Download
M media/filters/media_source_state.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M media/filters/source_buffer_stream.h View 2 chunks +7 lines, -8 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 8 chunks +39 lines, -36 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 208 chunks +473 lines, -434 lines 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
wolenetz
Created Revert of MSE: Relax the 'media segment must begin with keyframe' requirement
3 years, 3 months ago (2016-01-27 00:39:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637213002/1
3 years, 3 months ago (2016-01-27 00:41:29 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/139338)
3 years, 3 months ago (2016-01-27 00:53:56 UTC) #5
wolenetz
Silly presubmit source formatting rule failure (original code had bad format, revert tries to reinstate ...
3 years, 3 months ago (2016-01-27 00:59:32 UTC) #6
wolenetz
On 2016/01/27 00:59:32, wolenetz wrote: > Silly presubmit source formatting rule failure (original code had ...
3 years, 3 months ago (2016-01-27 01:01:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637213002/1
3 years, 3 months ago (2016-01-27 01:08:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 3 months ago (2016-01-27 01:54:38 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2016-01-27 01:56:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d3c457f2301754ca4321c77c8ff13e69dec8acc
Cr-Commit-Position: refs/heads/master@{#371686}

Powered by Google App Engine
This is Rietveld 408576698