Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: media/filters/media_source_state.h

Issue 1637213002: Revert of MSE: Relax the 'media segment must begin with keyframe' requirement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/frame_processor_unittest.cc ('k') | media/filters/media_source_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/media_source_state.h
diff --git a/media/filters/media_source_state.h b/media/filters/media_source_state.h
index 1a8e42adb409f36dc86095b39794d4c96a730ded..8d41b1ee0f1a52bbde87ec23987440ca6f893eb5 100644
--- a/media/filters/media_source_state.h
+++ b/media/filters/media_source_state.h
@@ -171,6 +171,16 @@
TimeDelta append_window_start_during_append_;
TimeDelta append_window_end_during_append_;
+ // Set to true if the next buffers appended within the append window
+ // represent the start of a new media segment. This flag being set
+ // triggers a call to |new_segment_cb_| when the new buffers are
+ // appended. The flag is set on actual media segment boundaries and
+ // when the "append window" filtering causes discontinuities in the
+ // appended data.
+ // TODO(wolenetz/acolwell): Investigate if we need this, or if coded frame
+ // processing's discontinuity logic is enough. See http://crbug.com/351489.
+ bool new_media_segment_;
+
// Keeps track of whether a media segment is being parsed.
bool parsing_media_segment_;
« no previous file with comments | « media/filters/frame_processor_unittest.cc ('k') | media/filters/media_source_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698