Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1637043002: Don't try to use ManagePasswordsBubbleModel if the password bubble was closed. (Closed)

Created:
4 years, 11 months ago by vasilii
Modified:
4 years, 11 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't try to use ManagePasswordsBubbleModel if the password bubble was closed. The bubble may be closed by some navigation in the content area. However, if the user pressed a button before closing and released after then the button action is still sent. Moreover, all the objects like NSWindow, NSWindowController, NSViewController are still alive. The UI code should not ping ManagePasswordsBubbleModel which is actually destroyed. BUG=579726 Committed: https://crrev.com/a3aaa89baf57b6cbbf4905ccbaccc4aedb08b4e7 Cr-Commit-Position: refs/heads/master@{#371513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -59 lines) Patch
M chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/pending_password_view_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm View 1 chunk +6 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm View 2 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm View 1 chunk +12 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller_unittest.mm View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
vasilii
Hi Vaclav, please review the CL.
4 years, 11 months ago (2016-01-26 14:06:39 UTC) #3
vabr (Chromium)
lgtm
4 years, 11 months ago (2016-01-26 14:35:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637043002/1
4 years, 11 months ago (2016-01-26 15:02:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 15:07:10 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 15:08:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3aaa89baf57b6cbbf4905ccbaccc4aedb08b4e7
Cr-Commit-Position: refs/heads/master@{#371513}

Powered by Google App Engine
This is Rietveld 408576698