Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1636953003: Fix length of DataView and TypedArray get/set functions (Closed)

Created:
4 years, 11 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix length of DataView and TypedArray get/set functions Functions like DataView.prototype.getUint8 should have length 1, and DataView.prototype.setUint8 should have length 2, as their endianness arguments are optional. Additionally, TypedArray.prototype.set.length should be 2. This follows the ES2015 specification, and a new test262 test tests for it. This patch fixes the functions' lengths. R=adamk Committed: https://crrev.com/3f37c4462bdab880066f8b40aa9fb1fb6415accf Cr-Commit-Position: refs/heads/master@{#33531}

Patch Set 1 #

Patch Set 2 : Also fix TypedArray.prototype.set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/js/typedarray.js View 1 3 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray.js View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Dan Ehrenberg
4 years, 11 months ago (2016-01-26 06:57:28 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636953003/1
4 years, 11 months ago (2016-01-26 06:57:44 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 07:18:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636953003/20001
4 years, 11 months ago (2016-01-26 18:49:38 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 19:22:22 UTC) #10
adamk
lgtm
4 years, 11 months ago (2016-01-26 23:08:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636953003/20001
4 years, 11 months ago (2016-01-26 23:54:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 23:55:59 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 23:56:18 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f37c4462bdab880066f8b40aa9fb1fb6415accf
Cr-Commit-Position: refs/heads/master@{#33531}

Powered by Google App Engine
This is Rietveld 408576698