Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: src/js/typedarray.js

Issue 1636953003: Fix length of DataView and TypedArray get/set functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Also fix TypedArray.prototype.set Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/es6/typedarray.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/typedarray.js
diff --git a/src/js/typedarray.js b/src/js/typedarray.js
index fd668a57fddceb2222d31d91ccad806dc5395bc8..7becd8947a5a9161b1584d3f1e2bfd93a223d7d3 100644
--- a/src/js/typedarray.js
+++ b/src/js/typedarray.js
@@ -460,6 +460,7 @@ function TypedArraySet(obj, offset) {
return;
}
}
+%FunctionSetLength(TypedArraySet, 1);
function TypedArrayGetToStringTag() {
if (!%_IsTypedArray(this)) return;
@@ -921,6 +922,7 @@ function DataViewGetTYPENAMEJS(offset, little_endian) {
offset = ToPositiveInteger(offset, kInvalidDataViewAccessorOffset);
return %DataViewGetTYPENAME(this, offset, !!little_endian);
}
+%FunctionSetLength(DataViewGetTYPENAMEJS, 1);
function DataViewSetTYPENAMEJS(offset, value, little_endian) {
if (!IS_DATAVIEW(this)) {
@@ -931,6 +933,7 @@ function DataViewSetTYPENAMEJS(offset, value, little_endian) {
offset = ToPositiveInteger(offset, kInvalidDataViewAccessorOffset);
%DataViewSetTYPENAME(this, offset, TO_NUMBER(value), !!little_endian);
}
+%FunctionSetLength(DataViewSetTYPENAMEJS, 2);
endmacro
DATA_VIEW_TYPES(DATA_VIEW_GETTER_SETTER)
« no previous file with comments | « no previous file | test/mjsunit/es6/typedarray.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698