third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp - Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: constants: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp ('k') | third_party/WebKit/Source/core/experiments/Experiments.cpp » ('j') | third_party/WebKit/Source/core/experiments/Experiments.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

index 3ab46dd5b836bd9e679a98b3b86277aa1c7f36df..c0e0b4515408b123be5ea7d8757fc10f8347854c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

@@ -195,7 +195,7 @@ void setCacheTimeStamp(CachedMetadataHandler* cacheHandler)

// Check previously stored timestamp.

bool isResourceHotForCaching(CachedMetadataHandler* cacheHandler, int hotHours)

{

- const double kCacheWithinSeconds = hotHours * 60 * 60;

+ const double cacheWithinSeconds = hotHours * 60 * 60;

unsigned tag = cacheTag(CacheTagTimeStamp, cacheHandler);

CachedMetadata* cachedMetadata = cacheHandler->cachedMetadata(tag);

if (!cachedMetadata)

@@ -204,7 +204,7 @@ bool isResourceHotForCaching(CachedMetadataHandler* cacheHandler, int hotHours)

const int size = sizeof(timeStamp);

ASSERT(cachedMetadata->size() == size);

memcpy(&timeStamp, cachedMetadata->data(), size);

- return (WTF::currentTime() - timeStamp) < kCacheWithinSeconds;

+ return (WTF::currentTime() - timeStamp) < cacheWithinSeconds;

}

// Final compile call for a streamed compilation. Most decisions have already