third_party/WebKit/Source/core/experiments/Experiments.cpp - Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/experiments/Experiments.cpp

Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: constants: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp » ('j') | third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/experiments/Experiments.cpp

diff --git a/third_party/WebKit/Source/core/experiments/Experiments.cpp b/third_party/WebKit/Source/core/experiments/Experiments.cpp

index 3d0af4904586452027b5b084b158e4d464ed7dd5..07bd0ec11e97f35a74e154caab49d2f0953f6440 100644

--- a/third_party/WebKit/Source/core/experiments/Experiments.cpp

+++ b/third_party/WebKit/Source/core/experiments/Experiments.cpp

@@ -17,7 +17,7 @@ namespace blink {

namespace {

-const char* kExperimentsMetaName = "api-experiments";

+ const char kExperimentsMetaName[] = "api-experiments";

Peter Kasting 2016/01/26 23:23:11 Bogus indenting? (And this is not the only file w

danakj 2016/01/26 23:36:18 Huh, ya clang-format doing it wrong here. I can ov

String getCurrentOrigin(ExecutionContext* executionContext)

{