Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1636873002: There is an unused rowBytes parameter being passed along. (Closed)

Created:
4 years, 11 months ago by cblume
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixing bug exposed by WritePixelsTest -- default parameters allowed me to accidentally pass the fla… #

Patch Set 3 : Removing unused parameter from writeSurfacePixels as well. #

Patch Set 4 : Fixing anotehr defaulted parameter bug. #

Patch Set 5 : It turns out writeSurfacePixels and writePixels were indeed using their rowBytes parameters. #

Patch Set 6 : Accidentally left in test code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M example/HelloWorld.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 43 (21 generated)
cblume
4 years, 11 months ago (2016-01-26 02:24:04 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636873002/1
4 years, 11 months ago (2016-01-26 02:27:50 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 11 months ago (2016-01-26 02:27:51 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/626)
4 years, 11 months ago (2016-01-26 02:38:43 UTC) #8
bsalomon
lgtm
4 years, 11 months ago (2016-01-26 14:32:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636873002/1
4 years, 11 months ago (2016-01-26 17:09:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/634)
4 years, 11 months ago (2016-01-26 17:14:20 UTC) #14
cblume
On 2016/01/26 17:14:20, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-26 17:40:52 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636873002/20001
4 years, 10 months ago (2016-02-08 23:05:31 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 23:45:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636873002/20001
4 years, 10 months ago (2016-02-10 18:57:59 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636873002/40001
4 years, 10 months ago (2016-02-10 20:42:21 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/6120)
4 years, 10 months ago (2016-02-10 20:45:20 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636873002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636873002/60001
4 years, 10 months ago (2016-02-10 21:11:11 UTC) #29
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/1093)
4 years, 10 months ago (2016-02-10 21:21:40 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636873002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636873002/80001
4 years, 10 months ago (2016-02-16 02:09:49 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636873002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636873002/100001
4 years, 10 months ago (2016-02-16 02:22:57 UTC) #35
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 02:44:05 UTC) #37
cblume
@bsalomon Does this still LGTY? I believe it is ready to land.
4 years, 10 months ago (2016-02-16 02:51:06 UTC) #38
bsalomon
lgtm
4 years, 10 months ago (2016-02-16 14:26:45 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636873002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636873002/100001
4 years, 10 months ago (2016-02-16 20:59:01 UTC) #41
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 21:00:04 UTC) #43
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/ed828001da75f4a3a5d31d9f1c1935e3595ce920

Powered by Google App Engine
This is Rietveld 408576698