example/HelloWorld.cpp - Issue 1636873002: There is an unused rowBytes parameter being passed along.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: example/HelloWorld.cpp

Issue 1636873002: There is an unused rowBytes parameter being passed along. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Accidentally left in test code. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: example/HelloWorld.cpp

diff --git a/example/HelloWorld.cpp b/example/HelloWorld.cpp

index 6833a33828ec9e44d43d66b4ad3da06fe75ae537..1cc18fdc8dd92d1ba19edd51082bc01348be0409 100644

--- a/example/HelloWorld.cpp

+++ b/example/HelloWorld.cpp

@@ -157,7 +157,7 @@ void HelloWorldWindow::draw(SkCanvas* canvas) {

if (kRaster_DeviceType == fType) {

// need to send the raster bits to the (gpu) window

SkImage* snap = fSurface->newImageSnapshot();

- size_t rowBytes;

+ size_t rowBytes = 0;

SkImageInfo info;

const void* pixels = snap->peekPixels(&info, &rowBytes);

fRenderTarget->writePixels(0, 0, snap->width(), snap->height(),

« no previous file with comments | « no previous file | src/gpu/GrContext.cpp » ('j') | no next file with comments »