Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1636853002: Timeline: simplify handling of event category colors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
index e3f5981c7f28a817bfe9b2debb23451ab29ae16f..97a665a55dc91759b5f95537afb3d53ba051b91e 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -182,13 +182,6 @@ WebInspector.TimelinePanel.prototype = {
wasShown: function()
{
- if (!WebInspector.TimelinePanel._categoryStylesInitialized) {
- WebInspector.TimelinePanel._categoryStylesInitialized = true;
- var style = createElement("style");
- var categories = WebInspector.TimelineUIUtils.categories();
- style.textContent = Object.values(categories).map(WebInspector.TimelineUIUtils.createStyleRuleForCategory).join("\n");
- this.element.ownerDocument.head.appendChild(style);
- }
WebInspector.context.setFlavor(WebInspector.TimelinePanel, this);
},
@@ -2008,7 +2001,7 @@ WebInspector.TimelineFilters.prototype = {
if (!category.visible)
continue;
var filter = new WebInspector.CheckboxFilterUI(category.name, category.title);
- filter.setColor(category.fillColorStop0, category.borderColor);
+ filter.setColor(category.color, "rgba(0, 0, 0, 0.2)");
categoryFiltersUI[category.name] = filter;
filter.addEventListener(WebInspector.FilterUI.Events.FilterChanged, categoriesFilterChanged.bind(this, categoryName));
this._filterBar.addFilter(filter);

Powered by Google App Engine
This is Rietveld 408576698