third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js - Issue 1636853002: Timeline: simplify handling of event category colors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 1636853002: Timeline: simplify handling of event category colors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

index 4914bb590bd18578b53c152420e70bf6e9b7f09d..7839b1814aca95a9607eca3747fc6b14a3668d84 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -711,13 +711,13 @@ WebInspector.AggregatedTimelineTreeView.prototype = {

case WebInspector.AggregatedTimelineTreeView.GroupBy.Category:

var category = categories[id] || categories["other"];

groupNode.name = category.title;

- groupNode.color = category.fillColorStop1;

+ groupNode.color = category.color;

break;

case WebInspector.AggregatedTimelineTreeView.GroupBy.Domain:

case WebInspector.AggregatedTimelineTreeView.GroupBy.Subdomain:

case WebInspector.AggregatedTimelineTreeView.GroupBy.URL:

groupNode.name = id || WebInspector.UIString("unattributed");

- groupNode.color = id ? WebInspector.TimelineUIUtils.eventColor(event) : categories["other"].fillColorStop1;

+ groupNode.color = id ? WebInspector.TimelineUIUtils.eventColor(event) : categories["other"].color;

break;

}

return groupNode;