Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1636853002: Timeline: simplify handling of event category colors (Closed)

Created:
4 years, 11 months ago by caseq
Modified:
4 years, 11 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: simplify handling of event category colors - only keep two colors per category, one for "self" and one for "children"; - name them appropriately; - drop gradients in legend swatches; - replace explicitly colored borders with semi-transparent grey; - fix legend for self time in pie chart summary. BUG=580487 Committed: https://crrev.com/238794efe3be27361f110c2db6aaba06fd7deab2 Cr-Commit-Position: refs/heads/master@{#371669}

Patch Set 1 : #

Messages

Total messages: 13 (6 generated)
caseq
4 years, 11 months ago (2016-01-26 00:25:23 UTC) #3
alph
lgtm
4 years, 11 months ago (2016-01-26 18:25:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636853002/20001
4 years, 11 months ago (2016-01-26 18:26:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/164612)
4 years, 11 months ago (2016-01-26 21:10:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636853002/20001
4 years, 11 months ago (2016-01-26 22:22:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-27 01:19:26 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 01:20:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/238794efe3be27361f110c2db6aaba06fd7deab2
Cr-Commit-Position: refs/heads/master@{#371669}

Powered by Google App Engine
This is Rietveld 408576698