Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 16368002: Make implicit things explicit when loading scripts. (Closed)

Created:
7 years, 6 months ago by Cutch
Modified:
7 years, 6 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make implicit things explicit when loading scripts. Explicitly: Set current working directory Set windows flag Previously these were side effects of calling other functions. Also use ' strings consistently. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=24099

Patch Set 1 #

Patch Set 2 : #

Total comments: 12

Patch Set 3 : Fix Issue 11232 #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -196 lines) Patch
M runtime/bin/builtin.dart View 1 2 6 chunks +101 lines, -91 lines 0 comments Download
M runtime/bin/dartutils.h View 1 2 3 2 chunks +12 lines, -1 line 0 comments Download
M runtime/bin/dartutils.cc View 1 2 3 7 chunks +258 lines, -104 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Cutch
7 years, 6 months ago (2013-06-05 20:43:19 UTC) #1
Ivan Posva
LGTMwC. -Ivan https://codereview.chromium.org/16368002/diff/2001/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/16368002/diff/2001/runtime/bin/builtin.dart#newcode69 runtime/bin/builtin.dart:69: bool _isWindows = false; Please set this ...
7 years, 6 months ago (2013-06-05 23:11:07 UTC) #2
siva
https://codereview.chromium.org/16368002/diff/2001/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/16368002/diff/2001/runtime/bin/builtin.dart#newcode114 runtime/bin/builtin.dart:114: String _resolveScriptUri(String scriptName) { How do we ensure that ...
7 years, 6 months ago (2013-06-06 01:13:17 UTC) #3
Cutch
https://codereview.chromium.org/16368002/diff/2001/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/16368002/diff/2001/runtime/bin/builtin.dart#newcode69 runtime/bin/builtin.dart:69: bool _isWindows = false; On 2013/06/05 23:11:07, Ivan Posva ...
7 years, 6 months ago (2013-06-12 19:34:26 UTC) #4
Ivan Posva
Still LGTM. -Ivan
7 years, 6 months ago (2013-06-14 06:42:48 UTC) #5
Cutch
7 years, 6 months ago (2013-06-17 15:59:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r24099 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698