Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1636773002: [Android] Fix bookmark row vertical alignment. (Closed)

Created:
4 years, 11 months ago by Kibeom Kim (inactive)
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix bookmark row vertical alignment. Fixed the followings: 1. Bookmark row text was aligned to the top. (regression from https://crrev.com/2cb98653338e23e4f31ade78de2ef872e697b2bc) 2. On offline section, selection-highlighting was not symmetric vertically. BUG=577996 Committed: https://crrev.com/6f36e2b333bcf4c9b0bfa920f3dcd1367cb256ea Cr-Commit-Position: refs/heads/master@{#371397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/res/layout/eb_row_content.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkBookmarkRow.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Kibeom Kim (inactive)
4 years, 11 months ago (2016-01-25 22:29:43 UTC) #2
Pete Williamson
LGTM Thanks!
4 years, 11 months ago (2016-01-25 22:59:58 UTC) #3
Kibeom Kim (inactive)
newt@: ptal chrome/android/java/res/layout/eb_row_content.xml
4 years, 11 months ago (2016-01-25 23:02:33 UTC) #5
newt (away)
lgtm
4 years, 11 months ago (2016-01-26 00:27:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636773002/1
4 years, 11 months ago (2016-01-26 00:33:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 01:15:50 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 01:17:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f36e2b333bcf4c9b0bfa920f3dcd1367cb256ea
Cr-Commit-Position: refs/heads/master@{#371397}

Powered by Google App Engine
This is Rietveld 408576698