Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkBookmarkRow.java

Issue 1636773002: [Android] Fix bookmark row vertical alignment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/eb_row_content.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkBookmarkRow.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkBookmarkRow.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkBookmarkRow.java
index 1b0a6129a7d1f64c0460a0efb2cd54d7a15e75c1..5011497833e89e3b6ecb0bc5e8534a127f8ae74e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkBookmarkRow.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkBookmarkRow.java
@@ -99,12 +99,12 @@ public class EnhancedBookmarkBookmarkRow extends EnhancedBookmarkRow implements
TextView textView = (TextView) findViewById(R.id.offline_page_size);
View bookmarkRowView = findViewById(R.id.bookmark_row);
if (offlinePage != null) {
- int bottomPadding = textView.getResources().getDimensionPixelSize(
+ int verticalPadding = textView.getResources().getDimensionPixelSize(
R.dimen.offline_page_item_vertical_spacing);
textView.setText(Formatter.formatFileSize(getContext(), offlinePage.getFileSize()));
// Get the embedded bookmark_row layout, and add padding. This is because the entries
// in filter view are larger (contain more items) than normal bookmark view.
- bookmarkRowView.setPadding(0, 0, 0, bottomPadding);
+ bookmarkRowView.setPadding(0, verticalPadding / 2, 0, verticalPadding / 2);
textView.setVisibility(View.VISIBLE);
} else {
textView.setVisibility(View.GONE);
« no previous file with comments | « chrome/android/java/res/layout/eb_row_content.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698