Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 1636703002: Implement MD specs for non-tabbed windows in Ash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more feedback addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 9eb6b54f7b88848b4a3f426e14c5dec9d8bebd4d..b89102554eb67a63bf90f1bd306fe22c0c0da106 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -3224,7 +3224,11 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, TestPopupBounds) {
// Minimum size that a popup window should have appended to its height when
// drawn (popup window bounds are for the content, not the window). This is
// the size of the toolbar on views platforms.
+#if defined(OS_CHROMEOS)
+ const int minimum_popup_padding = 27;
+#else
const int minimum_popup_padding = 29;
+#endif // defined(OS_CHROMEOS)
Peter Kasting 2016/02/10 02:43:58 For now, let's either disable this test, or change
tdanderson 2016/02/10 18:22:30 Done (crbug.com/585856). I have a funny feeling th
// Creates an untrusted popup window and asserts that the eventual height is
// padded with the toolbar and title bar height (initial height is content

Powered by Google App Engine
This is Rietveld 408576698