Implement MD specs for non-tabbed windows in Ash

chrome/browser/ui/browser_browsertest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
 
 #include "base/bind.h"
@@ skipping 3206 matching lines @@
   CheckDisplayModeMQ(ASCIIToUTF16("fullscreen"), app_contents);
 }
 
 // Test to ensure the bounds of popup, devtool, and app windows are properly
 // restored.
 IN_PROC_BROWSER_TEST_F(BrowserTest, TestPopupBounds) {
   {
     // Minimum size that a popup window should have appended to its height when
     // drawn (popup window bounds are for the content, not the window). This is
     // the size of the toolbar on views platforms.
+#if defined(OS_CHROMEOS)
+    const int minimum_popup_padding = 27;
+#else
     const int minimum_popup_padding = 29;
+#endif  // defined(OS_CHROMEOS)

[Peter Kasting, 2016/02/10 02:43:58]

For now, let's either disable this test, or change to check the content height
but check the erroneous value you found, and in either case add a TODO + file a
bug to do the right thing.

[tdanderson, 2016/02/10 18:22:30]

Done (crbug.com/585856). I have a funny feeling that the reported contents
bounds may vary by platform, but we'll see what the trybots say when running the
new test.

 
     // Creates an untrusted popup window and asserts that the eventual height is
     // padded with the toolbar and title bar height (initial height is content
     // height).
     Browser::CreateParams params(Browser::TYPE_POPUP, browser()->profile(),
                                  chrome::HOST_DESKTOP_TYPE_NATIVE);
     params.initial_bounds = gfx::Rect(0, 0, 100, 122);
     Browser* browser = new Browser(params);
     gfx::Rect bounds = browser->window()->GetBounds();
 
@@ skipping 64 matching lines @@
     Browser* browser = new Browser(params);
     gfx::Rect bounds = browser->window()->GetBounds();
 
     // Should be EXPECT_EQ, but this width is inconsistent across platforms.
     // See https://crbug.com/567925.
     EXPECT_GE(bounds.width(), 100);
     EXPECT_EQ(122, bounds.height());
     browser->window()->Close();
   }
 }