Allowing Lanczos3 to be used in chromium

Allowing Lanczos3 to be used in chromium

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13459

[Stephen White, 2014-02-13 14:51:15]

ATTN Rob: this will require setting SK_HIGH_QUALITY_IS_LANCZOS in Chrome's
skia_common.gypi, but *only* for desktop platforms (win, mac, linux). Android
and ChromeOS should be excluded. Thanks!

LGTM.

https://codereview.chromium.org/163663002/diff/1/src/effects/SkBitmapSource.cpp
File src/effects/SkBitmapSource.cpp (right):

https://codereview.chromium.org/163663002/diff/1/src/effects/SkBitmapSource.c...
src/effects/SkBitmapSource.cpp:74: SkPaint::kNone_FilterLevel :
SkPaint::kHigh_FilterLevel);
You should check if any of the css3/filters layout test results are affected by
this change with --enable-deferred-filters *not* set. (I don't think any are,
but I could be wrong). If so, let Robert know to suppress the failures on the
Skia roll.

[sugoi1, 2014-02-13 15:43:28]

https://codereview.chromium.org/163663002/diff/1/src/effects/SkBitmapSource.cpp
File src/effects/SkBitmapSource.cpp (right):

https://codereview.chromium.org/163663002/diff/1/src/effects/SkBitmapSource.c...
src/effects/SkBitmapSource.cpp:74: SkPaint::kNone_FilterLevel :
SkPaint::kHigh_FilterLevel);
On 2014/02/13 14:51:16, Stephen White wrote:
> You should check if any of the css3/filters layout test results are affected
by this change with --enable-deferred-filters *not* set. (I don't think any are,
but I could be wrong). If so, let Robert know to suppress the failures on the
Skia roll.

I didn't get any difference in css3/filters, but I got differences in
virtual/deferred/fast/images:

imagemap-focus-ring-zero-outline-width.html
jpeg-with-color-profile.html
png-with-color-profile.html
rgb-png-with-cmyk-color-profile.html
webp-color-profile-lossy.html
ycbcr-with-cmyk-color-profile.html

[Stephen White, 2014-02-13 15:58:40]

On 2014/02/13 15:43:28, sugoi1 wrote:
>
https://codereview.chromium.org/163663002/diff/1/src/effects/SkBitmapSource.cpp
> File src/effects/SkBitmapSource.cpp (right):
> 
>
https://codereview.chromium.org/163663002/diff/1/src/effects/SkBitmapSource.c...
> src/effects/SkBitmapSource.cpp:74: SkPaint::kNone_FilterLevel :
> SkPaint::kHigh_FilterLevel);
> On 2014/02/13 14:51:16, Stephen White wrote:
> > You should check if any of the css3/filters layout test results are affected
> by this change with --enable-deferred-filters *not* set. (I don't think any
are,
> but I could be wrong). If so, let Robert know to suppress the failures on the
> Skia roll.
> 
> I didn't get any difference in css3/filters, but I got differences in
> virtual/deferred/fast/images:
> 
> imagemap-focus-ring-zero-outline-width.html
> jpeg-with-color-profile.html
> png-with-color-profile.html
> rgb-png-with-cmyk-color-profile.html
> webp-color-profile-lossy.html
> ycbcr-with-cmyk-color-profile.html

I think that's ok. AFAIK, deferred decoding is only used on ChromeOS/Android,
which won't be affected by this change, and isn't yet used on Win/Mac/Linux.

[sugoi1, 2014-02-14 16:28:56]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2014-02-14 16:29:04]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/163663002/140001

[commit-bot: I haz the power, 2014-02-14 16:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 16:29:08]

Failed to apply patch for expectations/gm/ignored-tests.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file expectations/gm/ignored-tests.txt
  Hunk #1 FAILED at 42.
  1 out of 1 hunk FAILED -- saving rejects to file
expectations/gm/ignored-tests.txt.rej

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
4c0e83401294f639b17bc9284a8290a4e3137dce..9507bedf7ccb42534671e0b9cd1f41d5f2136a2d
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -42,3 +42,8 @@ extractbitmap
 shadertext3
 gradients_view_perspective
 drawbitmaprect
+
+# Need to rebaseline since SkBitmapSource was modified to use higher filter
quality
+# https://codereview.chromium.org/163663002/
+bitmapsource
+imagefiltersscaled

[sugoi1, 2014-02-14 18:12:35]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2014-02-14 18:12:45]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/163663002/220001

[commit-bot: I haz the power, 2014-02-14 18:46:11]

Change committed as 13459