Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1636593004: [turbofan] Disable test (Closed)

Created:
4 years, 11 months ago by sigurds
Modified:
4 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable test This CL disables a test that takes too long in debug mode when escape analysis is enabled in turbofan. R=machenbach@chromium.org BUG=v8:4586 LOG=n NOTRY=true Committed: https://crrev.com/a59653a2bf715b3591f1095ebd51fc2d06289d89 Cr-Commit-Position: refs/heads/master@{#33514}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add SLOW again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
sigurds
Hi Michael, as discussed I disabled the slow test. I changed SLOW to NO_VARIANTS, please ...
4 years, 11 months ago (2016-01-26 13:26:10 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/1636593004/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1636593004/diff/1/test/mjsunit/mjsunit.status#newcode282 test/mjsunit/mjsunit.status:282: 'regress/regress-1200351': [PASS, ['mode == debug', NO_VARIANTS]], Please keep ...
4 years, 11 months ago (2016-01-26 13:36:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636593004/1
4 years, 11 months ago (2016-01-26 13:36:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636593004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636593004/20001
4 years, 11 months ago (2016-01-26 13:39:39 UTC) #8
Michael Achenbach
lgtm
4 years, 11 months ago (2016-01-26 13:40:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 13:41:03 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 13:41:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a59653a2bf715b3591f1095ebd51fc2d06289d89
Cr-Commit-Position: refs/heads/master@{#33514}

Powered by Google App Engine
This is Rietveld 408576698