Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: src/IceAssemblerARM32.h

Issue 1636513002: Clean up emitInst() in the integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Remove ifdef 0 code. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceAssemblerARM32.cpp » ('j') | src/IceAssemblerARM32.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceAssemblerARM32.h
diff --git a/src/IceAssemblerARM32.h b/src/IceAssemblerARM32.h
index f7654b298666fea9b38965ae604b79c797195bd2..76ec3d0c809106ca4dd8af896d498f871147f582 100644
--- a/src/IceAssemblerARM32.h
+++ b/src/IceAssemblerARM32.h
@@ -455,7 +455,10 @@ private:
void bindCfgNodeLabel(const CfgNode *Node) override;
- void emitInst(IValueT Value) { Buffer.emit<IValueT>(Value); }
+ void emitInst(IValueT Value) {
+ AssemblerBuffer::EnsureCapacity ensured(&Buffer);
Jim Stichnoth 2016/01/25 16:57:14 John has a coding style I like where these RAII pl
Karl 2016/01/25 17:14:07 I really don't like this style! However, if we are
+ Buffer.emit<IValueT>(Value);
+ }
// List of possible checks to apply when calling emitType01() (below).
enum EmitChecks { NoChecks, RdIsPcAndSetFlags };
« no previous file with comments | « no previous file | src/IceAssemblerARM32.cpp » ('j') | src/IceAssemblerARM32.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698