Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1636503003: Error reporting for SVGLength and SVGLengthList (Closed)

Created:
4 years, 11 months ago by fs
Modified:
4 years, 11 months ago
Reviewers:
pdr., f(malita)
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Error reporting for SVGLength and SVGLengthList LoFi error reporting for SVGLength (LoFi because it uses the CSS parser, and hence can't provide locus information.) Minor cleanup in SVGLengthList, hoisting the call to clear(). Adding SVGParsingError::offsetWith to support the nested parsing going on in SVGLengthList. BUG=231612 Committed: https://crrev.com/d12b659e6ab8c9c2cf44fa14c407627afee10e5b Cr-Commit-Position: refs/heads/master@{#371288}

Patch Set 1 #

Patch Set 2 : TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLength.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthList.cpp View 3 chunks +9 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fs
Not the best error reporting, but at least the message is more specific... (https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/169728)
4 years, 11 months ago (2016-01-25 19:21:25 UTC) #2
pdr.
On 2016/01/25 at 19:21:25, fs wrote: > Not the best error reporting, but at least ...
4 years, 11 months ago (2016-01-25 19:41:55 UTC) #3
f(malita)
lgtm
4 years, 11 months ago (2016-01-25 19:43:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636503003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636503003/20001
4 years, 11 months ago (2016-01-25 19:46:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 19:58:00 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 19:59:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d12b659e6ab8c9c2cf44fa14c407627afee10e5b
Cr-Commit-Position: refs/heads/master@{#371288}

Powered by Google App Engine
This is Rietveld 408576698