Issue 16365008: ReturnValue::Set(uint32_t) is wrong

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16365008: ReturnValue::Set(uint32_t) is wrong (Closed)

Created:
7 years, 6 months ago by dcarney

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ReturnValue::Set(uint32_t) is wrong R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14990

Patch Set 3 : addressed comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -14 lines)			Patch
	M	include/v8.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1 2	3 chunks	+25 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dcarney

this fix is a little short. i was hoping to get it in before trunk ...

7 years, 6 months ago (2013-06-06 06:33:33 UTC) #2

Sven Panne

LGTM with a nit. https://codereview.chromium.org/16365008/diff/4001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/16365008/diff/4001/include/v8.h#newcode5677 include/v8.h:5677: bool fits_into_int32_t = (i & ...

7 years, 6 months ago (2013-06-07 07:05:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r14990.

Expand Messages | Collapse Messages

Issue 16365008: ReturnValue::Set(uint32_t) is wrong (Closed)

Description

Patch Set 1 #

Patch Set 2 : added tests #

Patch Set 3 : addressed comments #

Messages