ReturnValue::Set(uint32_t) is wrong

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 5656 matching lines @@
   if (V8_LIKELY(I::IsValidSmi(i))) {
     *value_ = I::IntToSmi(i);
     return;
   }
   Set(Integer::New(i, GetIsolate()));
 }
 
 template<typename T>
 void ReturnValue<T>::Set(uint32_t i) {
   typedef internal::Internals I;
-  if (V8_LIKELY(I::IsValidSmi(i))) {
-    *value_ = I::IntToSmi(i);
+  bool fits_into_int32_t = (i & (1 << 31)) == 0;

[Sven Panne, 2013/06/07 07:05:06]

I think 'i < INT32_MAX' is more readable than this bit fiddling, and we even
don't need a separate bool for this, as it is self-explaining.

+  if (V8_LIKELY(fits_into_int32_t)) {
+    Set(static_cast<int32_t>(i));
     return;
   }
   Set(Integer::NewFromUnsigned(i, GetIsolate()));
 }
 
 template<typename T>
 void ReturnValue<T>::Set(bool value) {
   typedef internal::Internals I;
   int root_index;
   if (value) {
@@ skipping 595 matching lines @@
 
 
 }  // namespace v8
 
 
 #undef V8EXPORT
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_