content/renderer/service_worker/service_worker_context_client.h - Issue 1636483002: Update the PushEvent to have a nullable PushMessageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/push_event_payload.h ('K') | « content/public/common/push_event_payload.h ('k') | content/renderer/service_worker/service_worker_context_client.cc » ('j') | content/renderer/service_worker/service_worker_context_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.h

diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h

index 6356e37bef016fafea20a9f22e7b15cb030b53d6..79e21a0db8dec6372067fe112d40e993b3a3ae90 100644

--- a/content/renderer/service_worker/service_worker_context_client.h

+++ b/content/renderer/service_worker/service_worker_context_client.h

@@ -53,6 +53,7 @@ namespace content {

struct NavigatorConnectClient;

struct PlatformNotificationData;

+struct PushEventPayload;

struct ServiceWorkerClientInfo;

class ServiceWorkerProviderContext;

class ServiceWorkerContextClient;

@@ -192,7 +193,7 @@ class ServiceWorkerContextClient

int64_t persistent_notification_id,

const PlatformNotificationData& notification_data,

int action_index);

- void OnPushEvent(int request_id, const std::string& data);

+ void OnPushEvent(int request_id, const content::PushEventPayload& payload);

Peter Beverloo 2016/01/26 12:35:18 s/content:://

harkness 2016/01/26 14:49:20 Done.

void OnGeofencingEvent(int request_id,

blink::WebGeofencingEventType event_type,

const std::string& region_id,