Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 9119c5712fa26e496dbd9bdc301a726f474231e4..f27f64e2b87a3a4c3f3f85e9e993d21e43c7ef40 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -32,6 +32,7 @@
#include "content/common/mojo/service_registry_impl.h"
#include "content/common/service_worker/embedded_worker_messages.h"
#include "content/common/service_worker/service_worker_messages.h"
+#include "content/public/common/push_event_payload.h"
#include "content/public/common/referrer.h"
#include "content/public/renderer/content_renderer_client.h"
#include "content/public/renderer/document_state.h"
@@ -760,11 +761,16 @@ void ServiceWorkerContextClient::OnNotificationClickEvent(
action_index);
}
-void ServiceWorkerContextClient::OnPushEvent(int request_id,
- const std::string& data) {
+void ServiceWorkerContextClient::OnPushEvent(
+ int request_id,
+ const content::PushEventPayload& payload) {
Peter Beverloo 2016/01/26 12:35:18 s/content:://
harkness 2016/01/26 14:49:20 Done.
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerContextClient::OnPushEvent");
- proxy_->dispatchPushEvent(request_id, blink::WebString::fromUTF8(data));
+ // Only set data to be a valid string if the payload had decrypted data.
+ blink::WebString data;
+ if (!payload.is_null_)
+ data.assign(blink::WebString::fromUTF8(payload.data_));
+ proxy_->dispatchPushEvent(request_id, data);
}
void ServiceWorkerContextClient::OnGeofencingEvent(

Powered by Google App Engine
This is Rietveld 408576698