content/browser/service_worker/service_worker_version.h - Issue 1636483002: Update the PushEvent to have a nullable PushMessageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/embedded_worker_test_helper.cc ('K') | « content/browser/service_worker/service_worker_internals_ui.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | content/browser/service_worker/service_worker_version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 96c54453043cc695265eb67c440b6f02a2f8f172..a1be7ea8d83ea67a467b2080a16583a450814cf7 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -53,6 +53,7 @@ class ServiceWorkerRegistration;

class ServiceWorkerURLRequestJob;

struct NavigatorConnectClient;

struct PlatformNotificationData;

+struct PushEventPayload;

struct ServiceWorkerClientInfo;

struct ServiceWorkerVersionInfo;

struct TransferredMessagePort;

@@ -276,7 +277,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

// This must be called when the status() is ACTIVATED.

void DispatchPushEvent(const StatusCallback& callback,

- const std::string& data);

+ const content::PushEventPayload& payload);

Peter Beverloo 2016/01/26 12:35:18 s/content:://

harkness 2016/01/26 14:49:20 Done.

// Sends a cross origin message event to the associated embedded worker and

// asynchronously calls |callback| when the message was sent (or failed to