content/browser/service_worker/service_worker_internals_ui.cc - Issue 1636483002: Update the PushEvent to have a nullable PushMessageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_internals_ui.cc

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/embedded_worker_test_helper.cc ('K') | « content/browser/service_worker/embedded_worker_test_helper.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | content/browser/service_worker/service_worker_version.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_internals_ui.cc

diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc

index ae899dca58d44108f095e745f2083862967ae021..ff0f81c7be4d37839fce1c060bd004569144ee19 100644

--- a/content/browser/service_worker/service_worker_internals_ui.cc

+++ b/content/browser/service_worker/service_worker_internals_ui.cc

@@ -26,6 +26,7 @@

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_ui.h"

#include "content/public/browser/web_ui_data_source.h"

+#include "content/public/common/push_event_payload.h"

#include "content/public/common/url_constants.h"

using base::DictionaryValue;

@@ -110,8 +111,9 @@ void DispatchPushEventWithVersionID(

callback.Run(SERVICE_WORKER_ERROR_NOT_FOUND);

return;

}

- std::string data = "Test push message from ServiceWorkerInternals.";

- version->DispatchPushEvent(callback, data);

+ PushEventPayload payload;

+ payload.setData("Test push message from ServiceWorkerInternals.");

+ version->DispatchPushEvent(callback, payload);

}

void UpdateVersionInfo(const ServiceWorkerVersionInfo& version,