Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1636453002: Use ASCII case-insensitive matching for ident-likes in the CSS parser (Closed)

Created:
4 years, 11 months ago by fs
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, kenneth.christiansen, rwlbuis, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ASCII case-insensitive matching for ident-likes in the CSS parser This CL replaces CSSParserToken::valueEqualsIgnoringCase and CSSParserString::equalIgnoringCase with valueEqualsIgnoringASCIICase and equalIgnoringASCIICase respectively - calling the similarly named function in WTF. Some cases where CSSParserToken::value() was coerced to a String is changed to avoid the coercion - using the CSSParserToken method directly. Similarly some cases that use the CSSParserString overload for equalIgnoringCase is changed to use the method on CSSParserToken. The dead equalIgnoringCase(const CSSParserString&, ...) function in LegacyCSSPropertyParser.cpp is removed. BUG=581001 Committed: https://crrev.com/b03ed6724b0805b5c1092167b2cfdf581e700545 Cr-Commit-Position: refs/heads/master@{#371500}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Consistent indentation in test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -64 lines) Patch
A third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSAtRuleID.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserString.h View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserValues.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserValuesTest.cpp View 2 chunks +22 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
4 years, 11 months ago (2016-01-25 16:34:06 UTC) #2
rune
lgtm https://codereview.chromium.org/1636453002/diff/1/third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html File third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html (right): https://codereview.chromium.org/1636453002/diff/1/third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html#newcode20 third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html:20: assert_equals(getComputedStyle(a).backgroundColor, "rgb(0, 128, 0)"); micro-nit: inconsistent indentation. 4 ...
4 years, 11 months ago (2016-01-25 18:28:41 UTC) #3
fs
https://codereview.chromium.org/1636453002/diff/1/third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html File third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html (right): https://codereview.chromium.org/1636453002/diff/1/third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html#newcode20 third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html:20: assert_equals(getComputedStyle(a).backgroundColor, "rgb(0, 128, 0)"); On 2016/01/25 at 18:28:41, rune ...
4 years, 11 months ago (2016-01-26 09:25:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636453002/20001
4 years, 11 months ago (2016-01-26 11:22:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 13:34:05 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 13:36:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b03ed6724b0805b5c1092167b2cfdf581e700545
Cr-Commit-Position: refs/heads/master@{#371500}

Powered by Google App Engine
This is Rietveld 408576698