third_party/WebKit/Source/core/css/parser/CSSParserString.h - Issue 1636453002: Use ASCII case-insensitive matching for ident-likes in the CSS parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserString.h

Issue 1636453002: Use ASCII case-insensitive matching for ident-likes in the CSS parser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Consistent indentation in test. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSParserToken.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSParserString.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserString.h b/third_party/WebKit/Source/core/css/parser/CSSParserString.h

index f3434ab6c590dd4263beae72eeb018389f09ae9e..e675cd20e3371b44bfc99813383b0f0724edceb2 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserString.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserString.h

@@ -81,13 +81,12 @@ struct CSSParserString {

return m_data.characters16[i];

}

- bool equalIgnoringCase(const char* str) const

+ template<unsigned matchLength>

+ bool equalIgnoringASCIICase(const char (&match)[matchLength]) const

{

- bool match = is8Bit() ? WTF::equalIgnoringCase(str, characters8(), length()) : WTF::equalIgnoringCase(str, characters16(), length());

- if (!match)

+ if (matchLength - 1 != length())

return false;

- ASSERT(strlen(str) >= length());

- return str[length()] == '\0';

+ return is8Bit() ? WTF::equalIgnoringASCIICase(characters8(), match, length()) : WTF::equalIgnoringASCIICase(characters16(), match, length());

}

operator String() const { return is8Bit() ? String(m_data.characters8, m_length) : StringImpl::create8BitIfPossible(m_data.characters16, m_length); }