Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1568)

Issue 1636343002: Drop dependency on ScopedPersistent from inspector/v8 (Closed)

Created:
4 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop dependency on ScopedPersistent from inspector/v8 v8::Global also clears itself on destruction R=pfeldman@chromium.org BUG=580337 Committed: https://crrev.com/82b43a106d4b785c002223d47255352d00815f8f Cr-Commit-Position: refs/heads/master@{#371811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M third_party/WebKit/Source/core/inspector/v8/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.cpp View 11 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jochen (gone - plz use gerrit)
4 years, 11 months ago (2016-01-27 08:25:39 UTC) #1
pfeldman
lgtm
4 years, 11 months ago (2016-01-27 17:00:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636343002/1
4 years, 11 months ago (2016-01-27 17:13:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 17:21:13 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 17:22:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82b43a106d4b785c002223d47255352d00815f8f
Cr-Commit-Position: refs/heads/master@{#371811}

Powered by Google App Engine
This is Rietveld 408576698