third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.h - Issue 1636343002: Drop dependency on ScopedPersistent from inspector/v8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.h

Issue 1636343002: Drop dependency on ScopedPersistent from inspector/v8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/DEPS ('k') | third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.h b/third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.h

index 902dd7479967b9f94fbbc8d2713d4b1b122acdb4..6a8727605fe2498bdf305bc6f4445cbe1f35f50a 100644

--- a/third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.h

+++ b/third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.h

@@ -32,7 +32,6 @@

#define JavaScriptCallFrame_h

-#include "bindings/core/v8/ScopedPersistent.h"

#include "bindings/core/v8/ScriptState.h"

#include "wtf/RefCounted.h"

#include "wtf/text/WTFString.h"

@@ -84,8 +83,8 @@ private:

v8::Isolate* m_isolate;

RefPtr<JavaScriptCallFrame> m_caller;

- ScopedPersistent<v8::Context> m_debuggerContext;

- ScopedPersistent<v8::Object> m_callFrame;

+ v8::Global<v8::Context> m_debuggerContext;

+ v8::Global<v8::Object> m_callFrame;

v8::Global<v8::FunctionTemplate> m_wrapperTemplate;

};