Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1636083002: Improve Observatory debugger behaviour when an isolate exits with unhandled exceptions (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 11 months ago
Reviewers:
bakster, rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve Observatory debugger behaviour when an isolate exits with unhandled exceptions - When an isolate is paused at exit and has a sticky error, have the debugger display the error. - Add --pause-isolates-on-unhandled-exceptions flag which sets a default value for break-on-exception. - Have the debugger display help text about 'set break-on-exception' and '--pause-isolates-on-unhandled-exceptions' - Signal an unhandled exception even if no client is connected to Observatory. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ec020a301b7885a00862531f031efd83eee83f14

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -13 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 4 chunks +24 lines, -2 lines 0 comments Download
A runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart View 1 1 chunk +27 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 9 chunks +26 lines, -10 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 11 months ago (2016-01-26 17:52:06 UTC) #4
rmacnak
lgtm
4 years, 11 months ago (2016-01-26 17:56:24 UTC) #5
Cutch
4 years, 11 months ago (2016-01-26 18:12:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ec020a301b7885a00862531f031efd83eee83f14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698