runtime/vm/debugger.cc - Issue 1636083002: Improve Observatory debugger behaviour when an isolate exits with unhandled exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 1636083002: Improve Observatory debugger behaviour when an isolate exits with unhandled exceptions (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger.cc

diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc

index 2d824a352fa0f397352c96b364f8be94e15b8686..731d8a08b3a738d5d0f2283d52c221082a2f5e1f 100644

--- a/runtime/vm/debugger.cc

+++ b/runtime/vm/debugger.cc

@@ -1628,7 +1628,6 @@ void Debugger::SignalExceptionThrown(const Instance& exc) {

// interested in exception events.

if (ignore_breakpoints_ ||

IsPaused() ||

- (!HasDebugEventHandler()) ||

(exc_pause_info_ == kNoPauseOnExceptions)) {

return;

}

« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »