src/ic/handler-compiler.h - Issue 1636013002: Replace HeapType with a non-templated FieldType class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/handler-compiler.h

Issue 1636013002: Replace HeapType with a non-templated FieldType class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix tracing of generalizations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/handler-compiler.h

diff --git a/src/ic/handler-compiler.h b/src/ic/handler-compiler.h

index 0c571fd34bd23b90933a6e79ff1077b7b5821d63..a03ce14696cfd78ee860aa14e883106ae16eb225 100644

--- a/src/ic/handler-compiler.h

+++ b/src/ic/handler-compiler.h

@@ -265,8 +265,8 @@ class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {

Label* miss_label);

- bool RequiresFieldTypeChecks(HeapType* field_type) const;

- void GenerateFieldTypeChecks(HeapType* field_type, Register value_reg,

+ bool RequiresFieldTypeChecks(FieldType* field_type) const;

+ void GenerateFieldTypeChecks(FieldType* field_type, Register value_reg,

Label* miss_label);

static Builtins::Name SlowBuiltin(Code::Kind kind) {