Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Issue 1635973002: Add GL_SAMPLER_CUBE_SHADOW to accepted uniform type (Closed)

Created:
4 years, 11 months ago by qiankun
Modified:
4 years, 11 months ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GL_SAMPLER_CUBE_SHADOW to accepted uniform type This CL adds missed uniform type in https://codereview.chromium.org/1349793004. Full supported uniform type can be found in Table 2.10, es spec 3.0.4 page 64. BUG=429053 Committed: https://crrev.com/e59a9c5c8bea63de4e931a0d276a1dbab38af298 Cr-Commit-Position: refs/heads/master@{#371702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gpu/command_buffer/service/program_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qiankun
This CL fixes deqp/functional/gles3/shadertexturefunction14.html. PTAL.
4 years, 11 months ago (2016-01-26 08:23:07 UTC) #2
Zhenyao Mo
On 2016/01/26 08:23:07, qiankun wrote: > This CL fixes deqp/functional/gles3/shadertexturefunction14.html. PTAL. lgtm
4 years, 11 months ago (2016-01-26 18:42:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635973002/1
4 years, 11 months ago (2016-01-27 02:36:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 03:23:49 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 03:25:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e59a9c5c8bea63de4e931a0d276a1dbab38af298
Cr-Commit-Position: refs/heads/master@{#371702}

Powered by Google App Engine
This is Rietveld 408576698