Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1349793004: Get LinkProgram to work with int/uint sampler variables. (Closed)

Created:
5 years, 3 months ago by Zhenyao Mo
Modified:
5 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get LinkProgram to work with int/uint sampler variables. Otherwise, with shaders using these uniform types, we encounter unknown uniform type and GPU process crash. BUG=532708, 429053 TEST=conformance2/textures/canvas/* R=piman@chromium.org Committed: https://crrev.com/464af71ad16a3ba315058002976a84e09f6d68ad Cr-Commit-Position: refs/heads/master@{#349320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M gpu/command_buffer/service/program_manager.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Zhenyao Mo
Verified. With this, a bunch of WebGL 2 tests crash. With this, they pass. piman: ...
5 years, 3 months ago (2015-09-16 23:46:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349793004/1
5 years, 3 months ago (2015-09-16 23:48:28 UTC) #3
piman
lgtm
5 years, 3 months ago (2015-09-16 23:50:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 01:26:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349793004/1
5 years, 3 months ago (2015-09-17 02:02:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 02:07:30 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 02:08:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/464af71ad16a3ba315058002976a84e09f6d68ad
Cr-Commit-Position: refs/heads/master@{#349320}

Powered by Google App Engine
This is Rietveld 408576698