content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 1635953002: Added replacement_range to ImeSetComposition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 1635953002: Added replacement_range to ImeSetComposition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: erikchen's review Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index a51d75e23852f0e0bc5e1c9b15e8994052f8157e..e12569ae557eed1e23c73bb6df082a8f8e07d17b 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -1624,6 +1624,7 @@ void RenderWidgetHostViewAura::SetCompositionText(

// TODO(suzhe): due to a bug of webkit, we can't use selection range with

// composition string. See: https://bugs.webkit.org/show_bug.cgi?id=37788

host_->ImeSetComposition(composition.text, underlines,

+ gfx::Range::InvalidRange(),

composition.selection.end(),

composition.selection.end());