content/browser/renderer_host/render_widget_host_view_aura_unittest.cc - Issue 1635953002: Added replacement_range to ImeSetComposition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 1635953002: Added replacement_range to ImeSetComposition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: erikchen's review Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

index 374adaf7afa355201721d2b1742846e9d26a12b9..b62a5c9f2ff84aa5e9ef2cebb4a02870c51d0d8a 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

@@ -1084,9 +1084,10 @@ TEST_F(RenderWidgetHostViewAuraTest, SetCompositionText) {

EXPECT_EQ(underlines[i].background_color,

base::get<1>(params)[i].backgroundColor);

}

+ EXPECT_EQ(gfx::Range::InvalidRange(), base::get<2>(params));

// highlighted range

- EXPECT_EQ(4, base::get<2>(params)) << "Should be the same to the caret pos";

EXPECT_EQ(4, base::get<3>(params)) << "Should be the same to the caret pos";

+ EXPECT_EQ(4, base::get<4>(params)) << "Should be the same to the caret pos";

}

view_->ImeCancelComposition();