Added replacement_range to ImeSetComposition

Added replacement_range to ImeSetComposition

Record replacementRange from setMarkedText: event, then send along with
next ImeSetComposition message.

BUG=460999
Committed: https://crrev.com/7eb752802da6d2df624f67855e5bb405a896b4b2
Cr-Commit-Position: refs/heads/master@{#371874}

[chongz, 2016-01-26 15:29:18]

chongz@chromium.org changed reviewers:
+ ccameron@chromium.org, dtapuska@chromium.org, erikchen@chromium.org

[chongz, 2016-01-26 15:29:19]

Can I have a review on this CL please?

I added 'replacement_range' to 'ImeSetComposition' and
'InputMsg_ImeSetComposition', but the consequence is I have to modified it in
lots of places.

I didn't change 'OnImeSetComposition' and 'SimulateImeSetComposition' in
'render_frame_impl' since they are not relevant to my fix, please let me know if
we want all the similar API have the same interface.

If this is the right way to do it I can work on adding tests.

Thanks!

[erikchen, 2016-01-26 18:25:01]

lgtm

https://codereview.chromium.org/1635953002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/1635953002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.mm:2251: // Clear
information got from |interpretKeyEvents:|
s/got//

[chongz, 2016-01-27 15:55:00]

chongz@chromium.org changed reviewers:
+ jam@chromium.org
- ccameron@chromium.org

[chongz, 2016-01-27 15:55:00]

Hi jam, can I have a review on other non-mac files please? (I saw you have
changes on 'render_view_impl.cc')
Thanks!

[jam, 2016-01-27 17:40:36]

lgtm

[chongz, 2016-01-27 18:34:00]

The CQ bit was checked by chongz@chromium.org

[chongz, 2016-01-27 18:34:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1635953002/#ps60001
(title: "erikchen's review")

[commit-bot: I haz the power, 2016-01-27 18:35:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1635953002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1635953002/60001

[commit-bot: I haz the power, 2016-01-27 18:49:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 18:49:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chongz, 2016-01-27 19:18:07]

chongz@chromium.org changed reviewers:
+ kenrb@chromium.org

[chongz, 2016-01-27 19:18:08]

Hi kenrb, can I have a review on 'input_messages.h' please?
Thanks!

[kenrb, 2016-01-27 20:13:15]

ipc lgtm

[chongz, 2016-01-27 20:16:54]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2016-01-27 20:18:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1635953002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1635953002/60001

[commit-bot: I haz the power, 2016-01-27 21:28:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-27 21:29:35]

Description was changed from

==========
Added replacement_range to ImeSetComposition

Record replacementRange from setMarkedText: event, then send along with
next ImeSetComposition message.

BUG=460999
==========

to

==========
Added replacement_range to ImeSetComposition

Record replacementRange from setMarkedText: event, then send along with
next ImeSetComposition message.

BUG=460999

Committed: https://crrev.com/7eb752802da6d2df624f67855e5bb405a896b4b2
Cr-Commit-Position: refs/heads/master@{#371874}
==========

[commit-bot: I haz the power, 2016-01-27 21:29:36]

Patchset 4 (id:??) landed as
https://crrev.com/7eb752802da6d2df624f67855e5bb405a896b4b2
Cr-Commit-Position: refs/heads/master@{#371874}