Issue 16359012: Manual Revert "Introduces the default sound for notifications."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16359012: Manual Revert "Introduces the default sound for notifications." (Closed)

Created:
7 years, 6 months ago by Jun Mukai

Modified:
7 years, 6 months ago

Reviewers:
Jun Mukai, James Hawkins, sreeram

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Manual Revert "Introduces the default sound for notifications." > Introduces the default sound for notifications. > > Currently no one is using this but will be used soon. > > BUG=164248 > R=dewittj@chromium.org, jhawkins@chromium.org > > Review URL: https://codereview.chromium.org/15896033 > > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203991 0039d316-1c4b-4281-b951-d872f2087c98 TBR=mukai@chromium.org, sreeram@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203997

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, -0 lines)			Patch
	M	chrome/browser/browser_resources.grd	View		1 chunk	+0 lines, -1 line	0 comments	Download
	D	chrome/browser/resources/notifications/default-notification.wav	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sreeram

On 2013/06/04 17:47:15, James Hawkins wrote: > What was the problem? Caused a sizes regression: ...

7 years, 6 months ago (2013-06-04 17:51:40 UTC) #3

Jun Mukai

7 years, 6 months ago (2013-06-04 17:53:18 UTC) #4

Message was sent while issue was closed.

On 2013/06/04 17:47:15, James Hawkins wrote:
> What was the problem?

failed at the size regression:
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/50993/
that's because the file is raw wav file -- and that's because since audio file
decoder cannot be loaded to the browser process.
I'll discuss with some other people about this before applying size increase.

Expand Messages | Collapse Messages