Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 15896033: Introduces the default sound for notifications. (Closed)

Created:
7 years, 6 months ago by Jun Mukai
Modified:
7 years, 6 months ago
Reviewers:
James Hawkins, dewittj
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Introduces the default sound for notifications. Currently no one is using this but will be used soon. BUG=164248 R=dewittj@chromium.org, jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --1 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/notifications/default-notification.wav View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jun Mukai
7 years, 6 months ago (2013-06-03 21:51:18 UTC) #1
dewittj
lgtm
7 years, 6 months ago (2013-06-04 01:18:28 UTC) #2
Jun Mukai
jhawkins, can you give the owner approval?
7 years, 6 months ago (2013-06-04 16:50:39 UTC) #3
James Hawkins
lgtm
7 years, 6 months ago (2013-06-04 17:04:53 UTC) #4
Jun Mukai
7 years, 6 months ago (2013-06-04 17:15:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r203991 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698