Replicating WebFrame::uniqueName across renderers.

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 2612caf128a20ba5c78dab342b5d4ee3c009a40f..25fac80524ba58906354131dc76fbc07a30521d1 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1386,7 +1386,10 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {
   GetRenderManager()->Init(site_instance.get(), view_routing_id,
                            params.main_frame_routing_id,
                            main_frame_widget_routing_id);
-  frame_tree_.root()->SetFrameName(params.main_frame_name);
+  // TODO(lukasza): Avoid having to duplicate how blink::FrameTree::setName
+  // calculates |unique_name| for the main frame.

[Charlie Reis, 2016/01/27 23:48:49]

I don't understand this TODO or how it relates to the code below.  Could you
clarify?

[Łukasz Anforowicz, 2016/01/28 01:21:19]

Both 1) the code below and 2) the code in FrameTree calculate unique name.  It
just turns out that calculating a unique name for a main frame means "just use
the name of the frame as the unique name", so hopefully duplicating this logic
below is ok.

I am not sure how to clarify the comment :-(

[Charlie Reis, 2016/02/11 22:02:13]

Oh, I see.  The only calculation here is an assignment.  I'm ok with your new
comment.

+  std::string unique_name = params.main_frame_name;
+  frame_tree_.root()->SetFrameName(params.main_frame_name, unique_name);
 
   WebContentsViewDelegate* delegate =
       GetContentClient()->browser()->GetWebContentsViewDelegate(this);