Replicating WebFrame::uniqueName across renderers.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 1368 matching lines @@
   int32_t view_routing_id = params.routing_id;
   int32_t main_frame_widget_routing_id = params.main_frame_widget_routing_id;
   if (main_frame_widget_routing_id == MSG_ROUTING_NONE) {
     view_routing_id = main_frame_widget_routing_id =
         site_instance->GetProcess()->GetNextRoutingID();
   }
 
   GetRenderManager()->Init(site_instance.get(), view_routing_id,
                            params.main_frame_routing_id,
                            main_frame_widget_routing_id);
-  frame_tree_.root()->SetFrameName(params.main_frame_name);
+  // TODO(lukasza): Avoid having to duplicate how blink::FrameTree::setName
+  // calculates |unique_name| for the main frame.

[Charlie Reis, 2016/01/27 23:48:49]

I don't understand this TODO or how it relates to the code below.  Could you
clarify?

[Łukasz Anforowicz, 2016/01/28 01:21:19]

Both 1) the code below and 2) the code in FrameTree calculate unique name.  It
just turns out that calculating a unique name for a main frame means "just use
the name of the frame as the unique name", so hopefully duplicating this logic
below is ok.

I am not sure how to clarify the comment :-(

[Charlie Reis, 2016/02/11 22:02:13]

Oh, I see.  The only calculation here is an assignment.  I'm ok with your new
comment.

+  std::string unique_name = params.main_frame_name;
+  frame_tree_.root()->SetFrameName(params.main_frame_name, unique_name);
 
   WebContentsViewDelegate* delegate =
       GetContentClient()->browser()->GetWebContentsViewDelegate(this);
 
 #if defined(MOJO_SHELL_CLIENT)
   if (MojoShellConnection::Get() &&
       base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kUseMusInRenderer)) {
     mus::Window* mus_window = aura::GetMusWindow(params.context);
     if (mus_window) {
@@ skipping 3346 matching lines @@
     const WebContentsObserver::MediaPlayerId& id) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, MediaStartedPlaying(id));
 }
 
 void WebContentsImpl::MediaStoppedPlaying(
     const WebContentsObserver::MediaPlayerId& id) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, MediaStoppedPlaying(id));
 }
 
 }  // namespace content