Replicating WebFrame::uniqueName across renderers.

content/browser/frame_host/frame_tree_node.cc

Index: content/browser/frame_host/frame_tree_node.cc
diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc
index 398ac8680b851728dd817520444a9b0af23e0a4a..2063ca4eb1912ec7d219b0cbc9b39e4950d9deae 100644
--- a/content/browser/frame_host/frame_tree_node.cc
+++ b/content/browser/frame_host/frame_tree_node.cc
@@ -78,6 +78,7 @@ FrameTreeNode::FrameTreeNode(
     RenderFrameHostManager::Delegate* manager_delegate,
     blink::WebTreeScopeType scope,
     const std::string& name,
+    const std::string& unique_name,
     const blink::WebFrameOwnerProperties& frame_owner_properties)
     : frame_tree_(frame_tree),
       navigator_(navigator),
@@ -94,6 +95,7 @@ FrameTreeNode::FrameTreeNode(
       replication_state_(
           scope,
           name,
+          unique_name,
           blink::WebSandboxFlags::None,
           false /* should enforce strict mixed content checking */),
       pending_sandbox_flags_(blink::WebSandboxFlags::None),
@@ -203,10 +205,12 @@ void FrameTreeNode::SetCurrentOrigin(const url::Origin& origin) {
   replication_state_.origin = origin;
 }
 
-void FrameTreeNode::SetFrameName(const std::string& name) {
+void FrameTreeNode::SetFrameName(const std::string& name,
+                                 const std::string& unique_name) {
   if (name != replication_state_.name)
     render_manager_.OnDidUpdateName(name);

[Charlie Reis, 2016/01/27 23:48:49]

Don't we need to broadcast the new unique_name to the proxies?  Or is there a
reason that's not needed?

Also, is it possible for the name to stay the same and the unique name to
change?  If so, we might need to broadcast the change in those cases as well.

[Łukasz Anforowicz, 2016/01/28 01:21:19]

Ooops.  Good catch - I looked at RenderFrameHostImpl::OnDidChangeName, but
didn't notice that we broadcast the change above.  

Done.
No - the unique name changes are tied to name changes (in blink::FrameTree).

   replication_state_.name = name;
+  replication_state_.unique_name = unique_name;
 }
 
 void FrameTreeNode::SetEnforceStrictMixedContentChecking(bool should_enforce) {