Replicating WebFrame::uniqueName across renderers.

third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/frame/FrameView.h"
 #include "core/html/HTMLIFrameElement.h"
 #include "platform/testing/URLTestHelpers.h"
 #include "platform/testing/UnitTestHelpers.h"
@@ skipping 306 matching lines @@
     webView->resize(WebSize(640, 480));
 
     // Create a remote root frame with a local child frame.
     FrameTestHelpers::TestWebRemoteFrameClient remoteClient;
     webView->setMainFrame(remoteClient.frame());
     remoteClient.frame()->setReplicatedOrigin(WebSecurityOrigin::createUnique());
 
     WebFrameOwnerProperties properties;
     FrameTestHelpers::TestWebFrameClient localFrameClient;
     WebRemoteFrame* rootFrame = webView->mainFrame()->toWebRemoteFrame();
-    WebLocalFrame* localFrame = rootFrame->createLocalChild(WebTreeScopeType::Document, "", WebSandboxFlags::None, &localFrameClient, nullptr, properties);
+    WebLocalFrame* localFrame = rootFrame->createLocalChild(WebTreeScopeType::Document, "name", "uniqueName", WebSandboxFlags::None, &localFrameClient, nullptr, properties);

[dcheng, 2016/02/16 22:17:29]

I would have expected name == uniqueName for most of these test cases.

[Łukasz Anforowicz, 2016/02/16 23:39:53]

In product code, we have name == uniqueName for the main frame, but for all
child frames this equality doesn't hold.

Additionally, there are new asserts that will complain when uniqueName.isEmpty
for a child frame (because of this we cannot have name == uniqueName in at least
some cases, like the first modified tests in
content/browser/frame_host/frame_tree_unittest.cc).

That said, I guess it is ok to have name == uniqueName in
FrameThrottlingTest.cpp and WebFrameTest.cpp.  I started making this change, but
I got hesitant - when I see/read |"name", "uniqueName"| I can reasonably guess
what both of these arguments are, but it is not so obvious when reading |"name",
"name"|.

WDYT?

[dcheng, 2016/02/19 18:14:57]

I don't know, it just seems weird to explicitly hardcode something in tests
that's different from what actually happens. Maybe we need a test helper for
createLocalChild / createRemoteChild: it'd probably be reasonable to add this to
FrameTestHelpers. createLocalChild() has a lot of arguments that are almost
always use default values in tests.

[Łukasz Anforowicz, 2016/02/19 19:56:59]

Good idea for introducing a helper - this reduces a lot of
boilerplate/noise/duplication.  OTOH, this still won't do exactly what the
product code would do, because it is not possible to calculate a |uniqueName|
via FrameTree without having a local parent.  Still - cheating in one place with
a comment is probably better than having this spread across multiple tests.

Done... sort-of...

 
     WebString baseURL("http://internal.test/");
     URLTestHelpers::registerMockedURLFromBaseURL(baseURL, "simple_div.html");
     FrameTestHelpers::loadFrame(localFrame, baseURL.utf8() + "simple_div.html");
 
     FrameView* frameView = toWebLocalFrameImpl(localFrame)->frameView();
     EXPECT_TRUE(frameView->frame().isLocalRoot());
 
     // Enable throttling for the child frame.
     frameView->setFrameRect(IntRect(0, 480, frameView->width(), frameView->height()));
@@ skipping 12 matching lines @@
 
     // Update the lifecycle again. The frame's lifecycle should not advance
     // because of throttling even though it is the local root.
     frameView->updateAllLifecyclePhases();
     testing::runPendingTasks();
     EXPECT_EQ(DocumentLifecycle::VisualUpdatePending, frameDocument->lifecycle().state());
     webView->close();
 }
 
 } // namespace blink