third_party/WebKit/Source/web/WebRemoteFrameImpl.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('K') | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp » ('j') | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.h

diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h

index ca92892ba210838de998961313897fb57d81cc68..993bf7120ab613c85dfae09fe034c332cb2a86c8 100644

--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h

+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h

@@ -149,7 +149,7 @@ public:

WebFrameImplBase* toImplBase() { return this; }

// WebFrameImplBase methods:

- void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& fallbackName) override;

+ void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& uniqueName) override;

RemoteFrame* frame() const override { return m_frame.get(); }

void setCoreFrame(PassRefPtrWillBeRawPtr<RemoteFrame>);

@@ -159,14 +159,14 @@ public:

static WebRemoteFrameImpl* fromFrame(RemoteFrame&);

// WebRemoteFrame methods:

- WebLocalFrame* createLocalChild(WebTreeScopeType, const WebString& name, WebSandboxFlags, WebFrameClient*, WebFrame* previousSibling, const WebFrameOwnerProperties&) override;

- WebRemoteFrame* createRemoteChild(WebTreeScopeType, const WebString& name, WebSandboxFlags, WebRemoteFrameClient*) override;

+ WebLocalFrame* createLocalChild(WebTreeScopeType, const WebString& name, const WebString& uniqueName, WebSandboxFlags, WebFrameClient*, WebFrame* previousSibling, const WebFrameOwnerProperties&) override;

+ WebRemoteFrame* createRemoteChild(WebTreeScopeType, const WebString& name, const WebString& uniqueName, WebSandboxFlags, WebRemoteFrameClient*) override;

void initializeFromFrame(WebLocalFrame*) const override;

void setReplicatedOrigin(const WebSecurityOrigin&) const override;

void setReplicatedSandboxFlags(WebSandboxFlags) const override;

- void setReplicatedName(const WebString&) const override;

+ void setReplicatedName(const WebString& name, const WebString& uniqueName) const override;

void setReplicatedShouldEnforceStrictMixedContentChecking(bool) const override;

void DispatchLoadEventForFrameOwner() const override;