content/browser/web_contents/web_contents_impl.cc - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/common/frame_messages.h » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 61bddb1d90a0f21c98a8c9f035a2ddaeb3a328f4..8cb0d2b14d29d60ab99bdbd28e9566cff0acf2b9 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1380,7 +1380,11 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {

GetRenderManager()->Init(site_instance.get(), view_routing_id,

params.main_frame_routing_id,

main_frame_widget_routing_id);

- frame_tree_.root()->SetFrameName(params.main_frame_name);

+ // blink::FrameTree::setName uses |name| as the |unique_name| for the main

+ // frame - let's do the same thing here.

+ std::string unique_name = params.main_frame_name;

+ frame_tree_.root()->SetFrameName(params.main_frame_name, unique_name);

WebContentsViewDelegate* delegate =

GetContentClient()->browser()->GetWebContentsViewDelegate(this);

« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/common/frame_messages.h » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')